Skip to content

remove unused dependencies#10

Open
erlendoksvoll wants to merge 1 commit intomainfrom
feature/remove-deps
Open

remove unused dependencies#10
erlendoksvoll wants to merge 1 commit intomainfrom
feature/remove-deps

Conversation

@erlendoksvoll
Copy link
Copy Markdown
Member

@erlendoksvoll erlendoksvoll commented Nov 17, 2025

Description

remove unused dependencies

Documentation

  • Doc updated

Summary by CodeRabbit

  • Chores
    • Removed unused package references from project files.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Nov 17, 2025

Walkthrough

Two NuGet package references were removed from project files: NewtonSoft.Json.Schema from the main plugin project and Moq from the test project. No other dependencies, target frameworks, or build configurations were altered.

Changes

Cohort / File(s) Summary
NuGet dependency removals
src/Dan.Plugin.Bits/Dan.Plugin.Bits.csproj, test/Dan.Plugin.Bits.Test/Dan.Plugin.Bits.Test.csproj
Removed NewtonSoft.Json.Schema package reference from plugin project; removed Moq (v4.20.72) package reference from test project. All other package references and project configurations remain unchanged.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The PR title 'remove unused dependencies' accurately reflects the primary change: removal of NewtonSoft.Json.Schema and Moq package references from project files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feature/remove-deps

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b8a7ab4 and 3177047.

📒 Files selected for processing (2)
  • src/Dan.Plugin.Bits/Dan.Plugin.Bits.csproj (1 hunks)
  • test/Dan.Plugin.Bits.Test/Dan.Plugin.Bits.Test.csproj (0 hunks)
💤 Files with no reviewable changes (1)
  • test/Dan.Plugin.Bits.Test/Dan.Plugin.Bits.Test.csproj
🔇 Additional comments (1)
src/Dan.Plugin.Bits/Dan.Plugin.Bits.csproj (1)

1-22: Verify that Dan.Common 1.8.0 does not depend on Newtonsoft.Json.Schema before merging.

Direct code inspection shows no usages of Newtonsoft.Json.Schema types in the source code, and the Moq removal from the test project is appropriate (no test dependencies on it). However, the code calls EvidenceValue.SchemaFromObject() from the Dan.Common 1.8.0 dependency, which is not publicly available. You must verify that Dan.Common 1.8.0 does not itself depend on Newtonsoft.Json.Schema, as an internal dependency there would cause runtime failures despite no direct code references in this project.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant