Transform creation_functions.md to rst #348
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
26 tasks
BvB93
reviewed
Dec 23, 2021
asmeurer
reviewed
Jan 3, 2022
Member
|
(I'm looking at all the md -> rst PRs) The overall formatting here looks fine. One unfortunate thing is that autosummary uses these brackets in the table instead of the actual Python signature: There isn't an option to disable this, but I found it can be disabled with a simple workaround in import sphinx.ext.autosummary as autosummary_mod
if hasattr(autosummary_mod, '_module'):
# It's a sphinx deprecated module wrapper object
autosummary_mod = autosummary_mod._module
autosummary_mod.mangle_signature = lambda sig, max_chars=30: sigIf you agree, I can make PR with this. |
asmeurer
reviewed
Jan 3, 2022
Member
Author
I think it is a good idea, please make the PR with this change :) |
asmeurer
added a commit
to asmeurer/array-api
that referenced
this pull request
Jan 10, 2022
Member
|
asmeurer
reviewed
Jan 10, 2022
kgryte
pushed a commit
that referenced
this pull request
Jan 11, 2022
…les (#364) As suggested here #348 (comment).
Member
|
Everything looks good here except for this question #345 (comment). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR converts the creation functions markdown into rst
Ref: #283