Add _format_str mapping to interchange protocol #62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kgryte
reviewed
Sep 7, 2021
Member
|
Thanks a lot @AlenkaF. Given that after gh-81 the implementation has been removed from this repo, and Pandas now has its own implementation merged (with significant improvements compared to the prototype that this PR was refactoring), I will close this PR. We did learn quite a bit from your Vaex implementation work. Thanks for opening this PR, and apologies it did not get merged last year. I will leave gh-54 open until we've verified that there's a test for this in https://github.com/data-apis/dataframe-interchange-tests, so we ensure that all four known implementations are indeed using the Arrow format strings. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a proposal to fix issue #54:
method
_format_strwas added to_PandasColumnwith mapping of basic string formats from NumPy to Apache Arrow C Data Interface.cc @kshitij12345 @rgommers