Skip to content

Conversation

@rhaswah
Copy link

@rhaswah rhaswah commented Mar 3, 2021

No description provided.

@rhaswah rhaswah requested a review from truongc2 March 3, 2021 17:25
@truongc2
Copy link
Collaborator

truongc2 commented Mar 3, 2021

Code looks good and EDA is detailed. Adding some requests for changes below:

  • Add markdown and provide a title
  • Put all module imports at the top of the file
  • Check your spacings i.e. cell 19
  • Use head / tail to preview the dataframe
  • In the markdown before cell 14, you have an incomplete sentence
  • Remove commented code
  • Rerun the notebook so the the cells are in order. Expect to rearrange the code as some variables are defined out of order
  • Consolidate the preprocessing steps so most if not all transformations happen in the same or nearby cells
  • Add "EDA" to the filename
  • Create a folder "EDA" and move the notebook into it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants