Skip to content

Conversation

@xinaxu
Copy link
Contributor

@xinaxu xinaxu commented Jul 26, 2023

No description provided.

@xinaxu xinaxu requested a review from masih July 26, 2023 15:35
type=semver,pattern={{raw}},value=${{ needs.version_bump.outputs.version }}
type=raw,value=latest,enable={{is_default_branch}}

- name: Build and push
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will also stop container publication to dockerhub, the container registry referenced in Singularity docs.

I recommend either keeping this bit or update docs to point to ghcr.io now that CI is building/publishing to it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will move it to ghcr.io.
I'll make the doc update in a different PR, or through gitbook directly.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know how widely used the docker hub container registry for singularity is. but the change seems worthy of some notice if that's going to break clients / silently stop having the latest.

@github-actions
Copy link

Suggested version: v0.2.47

Comparing to: v0.2.46 (diff)

Changes in go.mod file(s):

(empty)

gorelease says:

# diagnostics
go.sum: one or more sums are missing. Run 'go mod tidy' to add missing sums.
required module github.com/microcosm-cc/bluemonday@v1.0.1 retracted by module author: Retract older versions as only latest is to be depended upon

# summary
Suggested version: v0.2.47

gocompat says:

Your branch is up to date with 'origin/main'.

Cutting a Release (and modifying non-markdown files)

This PR is modifying both version.json and non-markdown files.
The Release Checker is not able to analyse files that are not checked in to main. This might cause the above analysis to be inaccurate.
Please consider performing all the code changes in a separate PR before cutting the release.

Automatically created GitHub Release

A draft GitHub Release has been created.
It is going to be published when this PR is merged.
You can modify its' body to include any release notes you wish to include with the release.

@xinaxu xinaxu merged commit 8e1a0f9 into main Jul 26, 2023
@xinaxu xinaxu deleted the xinaxu/version branch July 26, 2023 16:16
anjor pushed a commit to anjor/singularity that referenced this pull request Jun 14, 2025
Sankara-Jefferson pushed a commit to Sankara-Jefferson/singularity that referenced this pull request Jun 14, 2025
parkan pushed a commit that referenced this pull request Oct 22, 2025
parkan pushed a commit that referenced this pull request Oct 28, 2025
parkan pushed a commit that referenced this pull request Nov 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants