-
Notifications
You must be signed in to change notification settings - Fork 21
Remove autobump and update version.json #122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| type=semver,pattern={{raw}},value=${{ needs.version_bump.outputs.version }} | ||
| type=raw,value=latest,enable={{is_default_branch}} | ||
|
|
||
| - name: Build and push |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will also stop container publication to dockerhub, the container registry referenced in Singularity docs.
I recommend either keeping this bit or update docs to point to ghcr.io now that CI is building/publishing to it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will move it to ghcr.io.
I'll make the doc update in a different PR, or through gitbook directly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know how widely used the docker hub container registry for singularity is. but the change seems worthy of some notice if that's going to break clients / silently stop having the latest.
|
Suggested version: Changes in (empty)
Cutting a Release (and modifying non-markdown files)This PR is modifying both Automatically created GitHub ReleaseA draft GitHub Release has been created. |
No description provided.