chore/linter

[parkan]

fixes for linter env and lint errors

[parkan]

side note, I felt bad about breaking the build/release previously but apparently half of the recent https://github.com/golangci/golangci-lint/releases are broken/didn't have correct assets published so I'm in good company 😅

[parkan]

well, that took... quite a bit longer than ideal but we have a 🟢 build

notes:

• go version is now inferred from go.mod instead of specified in a bunch of places, this may be causing "go next" builds to not actually use go next, I need to review that but not having a single source of truth is 🤯
• a lot of linters have changed their behavior even with the same name and settings, we do our best to work with this
• suppressing the integer conversion overflow lint errors is not ideal but we are so freewheling with it in the codebase that I ended up throwing in the towel (aside from a few places where checks have been added, primarily file sizes) -- I did review each case flagged by the linter so far and concluded that under reasonable circumstances assumptions like "number of CAR flles or ranges are non-negative" will hold, however this is by no means suitable for use in adversarial environments
• I've tried to strike a balance between addressing legitimate concerns and not diverging too much from existing behaviors, the most significant change is that we're now always passing Server as pointer -- this may need a second set of eyes to find corner cases but I generally believe this to be correct and good
• github actions/workflows are the most cursed ecosystem

[zachfedor]

This is great! I was trying to follow the CONTRIBUTING.md guidelines but the make lint command was giving so much unrelated output, I was wondering if it was still being used. I appreciate the effort!

[parkan]

we might want to lock this but keeping the local version on latest does make it a bit more likely that we'll keep up with upstream changes