Fix: Safety check before migration subcommands #503
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Consistently optimise imports across all files and consistently format files. In go code, group SDK package imports together for better readability of non-sdk imports.
* Change swaggo annotation to unexported functions * Regenerate CLI reference * Regenerate swagger.json This solves #54
* Use a more reliable cron library to manage deal making push mode * Work in progress. Check in unfinished code before a long week leave.
Co-authored-by: Xinan Xu <39632914+xinaxu@users.noreply.github.com>
Co-authored-by: web3-bot <web3-bot@users.noreply.github.com>
So that the front end engineer from FF can be unblocked Also, unblock the CI actions
Reduce test time so CI runs faster
Basic coverage for deal making service
This creates a tester tool that can be used to export prepared CAR files to a folder structure so that the tester can verify the correctness of the preparation process. * folder CID -> folder * file CID -> file * Black box tests for now to unblock testers.
# Goals Move more code into handlers, so we can setup a library interface -- this removes the last major piece of logic code in the API # Implementation - HandlePostSource to CreateSourceHandler - A few cleanups around handler errors - Move PushItem under datasource directory (this is where one would expect it to be given the API syntax) - Fix tests to work with the handler - Adds a check on the parameter names to make sure they match the datasource type (reject inappropriately named params) - # For discussion This also fixes the build errors I introduced when I merged #85
…eal tracker and maker" This reverts commit ccf74ed.
Add CI workflows to build the Singularity container on each PR, and publish it onto ghcr.io for convenience on merge to main and tagged versions.
Update code to use `any` keyword instead of `interface{}` since the go mod version is 1.19.
The changes here are purely cosmetic and have no effect on net functionality.
Allow only once instance of deal maker and deal tracker. Later we will also only allow one instance of metrics reporter.
- [x] Testnet/Calibnet can be enabled by setting * LOTUS_API * MARKET_DEAL_URL * The genesis timestamp will be figured out by calling lotus.ChainGetGenesis, or default to mainnet genesis timestamp if LOTUS_API is the default GLIF mainnet API endpoint - [x] Remove places that set address.CurrentNetwork
`go generate` is run during CI to check if any file is not updated. Below files are automatically generated * data source add swagger annotation will be generated from supported Rclone backend options * swagger file will be generated from swagger annotation * CLI reference will be generated from capturing the help page for all subcommands * WebAPI reference will be generated from the swagger file Plus some other fixes * Changed the documentation to point to the ghcr.io for installing via docker * The doc generated will use no longer use current user as the default value but a string literal '$USER' instead * The default sqlite database is the one from the current directory instead of assuming there is a home directory * Fix a race condition from zstd Read and Close at the same time by wrapping it in a thread safe struct
adds an API for interacting with singularity over HTTP or through code
This enables use of HTTP_PROXY (ws transports) and TCP_PROXY (tcp transport) in addition to other enhancements. Includes a doc generate and other chores.
- update go-libp2p to v0.39.1 - enable HTTP(S)_PROXY and TCP_PROXY
fixes for linter env and lint errors --------- Co-authored-by: Arkadiy Kukarkin <arkadiy@archive.org>
- Add init function to create full current schema on brand new clean databases and run missing migrations on any databases using old auto-migrate strategy with existing data. - Add CLI commands to migrate up, down, or to a specified version by ID - Add utility functions to get list of migration IDs ran on current database, check if migration has run by ID, etc.
Fix struct tag ordering in handler/storage/types_gen.go to match the current code generator output. This resolves CI failures where go generate was detecting differences between committed and generated files.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #503 +/- ##
==========================================
- Coverage 74.05% 70.68% -3.37%
==========================================
Files 150 157 +7
Lines 9980 10477 +497
==========================================
+ Hits 7391 7406 +15
- Misses 1828 2317 +489
+ Partials 761 754 -7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
16 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relies on #496
This adds a quick check before any
singularity admin migration ...subcommands are run to inform the user they have to runsingularity admin initfirst to transition to the new versioned migration strategy.