our eda for code review assignment#4
Open
lizaoh wants to merge 17 commits intodata-science-methods:masterfrom
Open
our eda for code review assignment#4lizaoh wants to merge 17 commits intodata-science-methods:masterfrom
lizaoh wants to merge 17 commits intodata-science-methods:masterfrom
Conversation
dhicks
assigned
dschloesser720 and
emilio-lobato and unassigned
dschloesser720 and
emilio-lobato
Comment on lines
+17
to
+19
| #' The data shows that there are 28 variables, but the README file only mention 27. It appears that | ||
| #' "ALPHA_3" is the additional variable on the dataset. It is a character variable with 160 unique abservations | ||
| #' in it. |
There was a problem hiding this comment.
Thoroughly commented throughout.
Comment on lines
+28
to
+29
| set.seed(2020-10-22) | ||
| soc_small <- sample_n(soccer_data, 15000) |
There was a problem hiding this comment.
Good call creating this new dataset for viewing the data, keeping in mind the run times. Thank you!
| library(skimr) | ||
| library(visdat) | ||
| library(ggplot2) | ||
|
|
There was a problem hiding this comment.
General comment: We are unsure what the overall question is that motivated the EDA. The questions being asked here are implied but not stated.
| #' The plot above seems to show that Spain has a higher tendency than the other countries in the league | ||
| #' to associate white with good and black with bad. However this visualization might not be the best. | ||
| #' Let's looks at histograms per Country | ||
|
|
There was a problem hiding this comment.
The visualizations are nice, good work!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.