Skip to content

CARDS-2130: Increase test coverage of cards-data-model-subjects-impl #1392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
sofi2002sofi wants to merge 5 commits into
base: dev
Choose a base branch
from
Open

CARDS-2130: Increase test coverage of cards-data-model-subjects-impl #1392

sofi2002sofi wants to merge 5 commits into from

Conversation

@sofi2002sofi
Copy link
Contributor

@sofi2002sofi sofi2002sofi commented Feb 27, 2023

No description provided.

@sofi2002sofi sofi2002sofi marked this pull request as ready for review March 10, 2023 00:11
@sofi2002sofi sofi2002sofi requested a review from sdumitriu April 12, 2023 15:12
@veronikaslc
Copy link
Contributor

veronikaslc commented Jun 16, 2023 •
edited
Loading

SubjectFullIdentifierEditorTest and SubjectParentEditorTest: case of RepositoryException if accessing the repository fails is not coved.
SubjectQuickSearchEngineTest, BareSubjectProcessoTest: case of RepositoryException is not covered too.
AbstractSubjectToStringSerializerTest: case of if (!"cards:Form".equals(nodeType)) is not covered from line 162 of AbstractSubjectToStringSerializer.
SimpleSubjectProcessorTest: not all cases covered from line 83 of SimpleSubjectProcessor.

@veronikaslc
Copy link
Contributor

veronikaslc commented Jun 16, 2023

jacoco.zip
jacoco:report html file attached

@sofi2002sofi sofi2002sofi force-pushed the CARDS-2130-subjects-tests branch from b9e891a to 24be156 Compare August 5, 2023 20:53
@veronikaslc veronikaslc force-pushed the CARDS-2130-subjects-tests branch from 24be156 to d036535 Compare December 4, 2025 20:20
@veronikaslc veronikaslc force-pushed the CARDS-2130-subjects-tests branch from d036535 to 0f08fbf Compare December 6, 2025 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sdumitriu sdumitriu Awaiting requested review from sdumitriu

At least 1 approving review is required to merge this pull request.

Assignees

@veronikaslc veronikaslc

Labels

test-coverage

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sofi2002sofi @veronikaslc @marta-