Skip to content

Conversation

@marta-
Copy link
Contributor

@marta- marta- commented Feb 13, 2024

DRAFT because it's being published untested.

To test:

  • setting displayMode: select on text, long, decimal and vocabulary questions from the questionnaire designer
  • how the select questions that accept multiple answer values are behaving in the form edit mode
  • check that answer options with both value and label are displayed and working correctly for select questions
  • check that na options are behaving as expected for multi-valued select questions

@marta- marta- requested a review from sashaandjic February 13, 2024 18:58
@marta- marta- added Test me! Ready for testing easy to review Very few changes, very small time investment to review labels Feb 13, 2024
@sdumitriu
Copy link
Member

No select for double, resource, or vocabulary questions?

@marta-
Copy link
Contributor Author

marta- commented Feb 13, 2024

No select for double, resource, or vocabulary questions?

We don't support answer options for double questions since we discovered issues with "matching" double values to options a while ago, so select doesn't currently apply to this data type.

Resource questions already have the select display mode.

I can add select to vocabulary questions, even though I find it as useless as the simple list display mode in this case, but it doesn't hurt so why not.

@sdumitriu
Copy link
Member

No select for double, resource, or vocabulary questions?

Resource questions already have the select display mode.

Right, I missed it because all other instances have more than just an empty object.

@marta-
Copy link
Contributor Author

marta- commented Feb 13, 2024

No select for double, resource, or vocabulary questions?

We don't support answer options for double questions since we discovered issues with "matching" double values to options a while ago, so select doesn't currently apply to this data type.

See fedf974 .

I can add select to vocabulary questions, even though I find it as useless as the simple list display mode in this case, but it doesn't hurt so why not.

Added in 0c045e9 .

@sashaandjic sashaandjic added testing... Testing in progress bug Something isn't working and removed testing... Testing in progress labels Feb 13, 2024
@sashaandjic
Copy link
Contributor

image

@sashaandjic sashaandjic added testing... Testing in progress bug Something isn't working Test me! Ready for testing and removed bug Something isn't working Test me! Ready for testing testing... Testing in progress labels Mar 5, 2024
@sashaandjic sashaandjic removed the Test me! Ready for testing label Sep 24, 2024
@marta- marta- removed the bug Something isn't working label Feb 1, 2025
@marta-
Copy link
Contributor Author

marta- commented Feb 1, 2025

Rebased on the latest dev. NA behavior issue addressed in a3035cf.

@marta-
Copy link
Contributor Author

marta- commented Feb 1, 2025

Known issue - JS console warning: Failed prop type: Invalid prop questionDefinition.displayMode of value select supplied to TextQuestion, expected one of [null,"input","textbox","list","list+input","hidden"]. This will disappear once we upgrade to the React version that deprecates PropTypes.

@marta- marta- marked this pull request as ready for review February 1, 2025 00:30
marta- and others added 3 commits December 11, 2025 15:32
…splay mode for multiple choice questions

Added the `select` display mode option to vocabulary questions.
…splay mode for multiple choice questions

Correct handling of "NA", "None of the above" options
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

easy to review Very few changes, very small time investment to review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants