CARDS:2797: Enforce various useful ESLint rules #2137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
DRAFT |
veronikaslc
force-pushed
the
CARDS-2797
branch
2 times, most recently
from
377804d to
fad766b
Compare
marta-
reviewed
Dec 18, 2025
| setters["local"](phase); | ||
| } | ||
| if (setters.hasOwnProperty("remote")) { | ||
| if (Object.prototype.hasOwnProperty.call(setters, "remote")) { |
Contributor
There was a problem hiding this comment.
All these hasOwnProperty calls look like ancient code... For example here, can't we just replace lines 108-110 with
setters["remote"]?.(phase);
?
Similar approaches for all the other occurrences.
Contributor
Author
There was a problem hiding this comment.
Linter told to replace such if hasOwnProperty is used, your suggestion is better ofcourse
marta-
reviewed
Dec 18, 2025
Contributor
There was a problem hiding this comment.
This commit should be pulled in a separate PR, it would be merged immediately.
marta-
reviewed
Dec 18, 2025
Contributor
There was a problem hiding this comment.
This commit fixes 3 actual bugs and should be made into a separate PR for immediate merge.
veronikaslc
force-pushed
the
CARDS-2797
branch
from
fad766b to
1943a77
Compare
marta-
reviewed
Dec 18, 2025
| onClick={(e) => { | ||
| disableDropdownItemLink && setSearch(result.entityIdentifier); | ||
| onSelect(e, result, props); | ||
| onSelect ? onSelect(e, result, props) : defaultRedirect(e, result, props); |
Contributor
There was a problem hiding this comment.
Just curious, does this shorter version work?
(onSelect ?? defaultRedirect)(e, result, props);
1943a77 to
c33fa07
Compare
Added an ESLint recommended rules Turned off no-undef and no-extra-boolean-cast rules
Fixed react-hooks/rules-of-hooks rule
- Migrated deprecated core ESLint codestyle rules to the @stylistic/eslint-plugin - Fixed emerged codestyle errors - Extend recommended rules via spreading - Removed js from commonPlugins because @eslint/js is not a plugin in flat config - Added jsxA11y to plugins for future use
Extended on react.configs.recommended.rules Removed react duplicated rules that are already included in recommended set
Extended rules on accessibility rules jsxA11y.configs.recommended.rules
Added react rule to report unused prop types
Added stylistic rule to monitor extra semicolimn
veronikaslc
force-pushed
the
CARDS-2797
branch
from
c33fa07 to
33584e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.