Fix for pip flags with equal sign being incorrectly treated as local file names #3766
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewnester
requested review from
anton-107,
denik,
pietern and
shreyas-goenka
as code owners
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Collaborator
7 failing tests:
|
pietern
approved these changes
Oct 15, 2025
| // Alternatively it could be a flag with no argument and no space after it | ||
| // For example: -r myfile.txt or --index-url http://myindexurl.com or -i | ||
| re := regexp.MustCompile(`(^|\s+)--?[a-zA-Z0-9-]+(\s+|$)`) | ||
| re := regexp.MustCompile(`(^|\s+)--?[a-zA-Z0-9-]+(([\s|=]+)|$)`) |
Contributor
There was a problem hiding this comment.
Nit: I think you only need ([\s=]|$) -- either a space, an =, or the end of the string.
More than one space or = doesn't change the result.
deco-sdk-tagging bot
added a commit
that referenced
this pull request
Oct 16, 2025
## Release v0.273.0 ### Notable Changes * (via Terraform v1.92.0) DABs will no longer try to update pipeline permissions upon pipeline deletion. This fixes PERMISSION\_ERROR upon 'bundle destroy' for pipelines that have run\_as setting enabled (described in https://community.databricks.com/t95/data-engineering/dab-dlt-destroy-fails-due-to-ownership-permissions-mismatch/td-p/132101) The downside is that if 'permissions:' block is removed from the resource, DABs will not try anymore to restore permissions to just the owner of the pipeline. ### CLI * Add the `--configure-serverless` flag to `databricks auth login` to configure Databricks Connect to use serverless. ### Dependency updates * Upgrade Go SDK to 0.82.0 ([#3769](#3769)) * Upgrade TF provider to 1.92.0 ([#3772](#3772)) ### Bundles * Updated the internal lakeflow-pipelines template to use an "src" layout ([#3671](#3671)). * Fix for pip flags with equal sign being incorrectly treated as local file names ([#3766](#3766))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fix for pip flags with equal sign being incorrectly treated as local file names
Why
Pip flags containing an equal sign and used in the environment dependencies section were incorrectly treated as local file names, leading to the bundle deploy error.
Tests
Added test case for this