-
Notifications
You must be signed in to change notification settings - Fork 127
Implement wsfix target to automatically fix whitespace issues #3983
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This equalizes a diff with the current version of the templates.
- Add --fix flag support to validate_whitespace.py - Add wsfix target to Makefile for automatic whitespace fixing - Fix trailing whitespace and newline issues in 169 files
093e5dd to
e9e4e9f
Compare
shreyas-goenka
approved these changes
Nov 21, 2025
Collaborator
|
Commit: 10dd023
363 failing tests:
Top 19 slowest tests (at least 2 minutes):
|
Contributor
|
--fix mode is nice, but should not we fix the template instead? |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 21, 2025
## Changes This equalizes a diff with the current version of the templates. Note: the whitespace diffs in the apps commands came from #3948. I'm making another change to clean those up and enable the whitespace linter for all generated files in #3983. ## Why A few changes in the upstream templates caused drift.
Contributor
Author
|
I don't think we can enforce this upstream yet, so not having/doing |
Collaborator
|
Commit: 51e416d
40 failing tests:
Top 50 slowest tests (at least 2 minutes):
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
wsfixMakefile target and call it after codegen.wsignoreWhy
Whitespace issues cause unnecessary diffs.