Skip to content

[PECO-1433] Support Databricks OAuth on GCP #224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kravets-levko merged 1 commit into from
Feb 1, 2024
Merged

[PECO-1433] Support Databricks OAuth on GCP #224

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions lib/connection/auth/DatabricksOAuth/OAuthManager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,6 +197,13 @@ export default abstract class OAuthManager {
return new DatabricksOAuthManager(options);
}

const gcpDomains = ['.gcp.databricks.com'];
const isGCPDomain = gcpDomains.some((domain) => host.endsWith(domain));
if (isGCPDomain) {
// eslint-disable-next-line @typescript-eslint/no-use-before-define
return new DatabricksOAuthManager(options);
}

if (options.useDatabricksOAuthInAzure) {
const domains = ['.azuredatabricks.net'];
const isSupportedDomain = domains.some((domain) => host.endsWith(domain));
Expand Down
13 changes: 13 additions & 0 deletions tests/unit/DBSQLClient.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -363,6 +363,19 @@ describe('DBSQLClient.initAuthProvider', () => {
expect(provider.manager).to.be.instanceOf(AzureOAuthManager);
});

it('should use Databricks OAuth method (GCP)', () => {
const client = new DBSQLClient();

const provider = client.initAuthProvider({
authType: 'databricks-oauth',
// host is used when creating OAuth manager, so make it look like a real AWS instance
host: 'example.gcp.databricks.com',
});

expect(provider).to.be.instanceOf(DatabricksOAuth);
expect(provider.manager).to.be.instanceOf(DatabricksOAuthManager);
});

it('should use Databricks InHouse OAuth method (Azure)', () => {
const client = new DBSQLClient();

Expand Down