Infer missing arrow schema #233
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Levko Kravets <levko.ne@gmail.com>
Signed-off-by: Levko Kravets <levko.ne@gmail.com>
kravets-levko
requested review from
andrefurlan-db,
arikfr,
rcypher-databricks,
superdupershant and
yunbodeng-db
as code owners
kravets-levko
temporarily deployed
to
azure-prod
GitHub Actions
Inactive
andrefurlan-db
approved these changes
Mar 8, 2024
andrefurlan-db
left a comment
andrefurlan-db
left a comment
There was a problem hiding this comment.
I don't know the risk of regression, but assuming you have tested, the code looks good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Older DBR versions may not return a serialized Arrow schema in
TGetResultSetMetadataResp. But schema in Arrow binary format is required to deserialize Arrow batches (which contain only rows). Python connector has a code that converts Hive schema to Arrow, and this PR adds similar solution to Node connector.Fixes #232