Skip to content

Conversation

@kravets-levko
Copy link
Contributor

@kravets-levko kravets-levko commented Apr 23, 2024

Each commit is a separate change:

  • Get rid of redundant lib/hive/Types - some types there were just re-exports, some were used in the only place, some were unused at all. The only type that was used more than once was replaced by a function
  • Allow any number type (number, bigint, Int64) for maxRows and queryTimeout (related to Documentation on timeout options needs clarification #167)
  • Move some global constants to client config
  • Add a note about queryTimeout option (also related to Documentation on timeout options needs clarification #167)
  • Use a dedicated AuthenticationError class instead of a generic Error for errors in auth-related code

Signed-off-by: Levko Kravets <levko.ne@gmail.com>
…yTimeout` options

Signed-off-by: Levko Kravets <levko.ne@gmail.com>
Signed-off-by: Levko Kravets <levko.ne@gmail.com>
Signed-off-by: Levko Kravets <levko.ne@gmail.com>
@databricks databricks deleted a comment from codecov-commenter Apr 23, 2024
@kravets-levko kravets-levko changed the title Chore Chore (WIP) Apr 23, 2024
Signed-off-by: Levko Kravets <levko.ne@gmail.com>
@kravets-levko kravets-levko changed the title Chore (WIP) Chore Apr 23, 2024
@databricks databricks deleted a comment from codecov-commenter Apr 23, 2024
@kravets-levko kravets-levko merged commit c239fca into main Apr 29, 2024
@kravets-levko kravets-levko deleted the chores-2024-04-23 branch April 29, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants