Skip to content

Conversation

@jprakash-db
Copy link
Collaborator

Description

PyArrow has been added to the pyproject.toml file

@jprakash-db jprakash-db self-assigned this Nov 14, 2024
@jprakash-db jprakash-db merged commit fef6428 into main Nov 14, 2024
@dhirschfeld
Copy link
Contributor

This is not a good PR description. Anyone who clicks on the Files changed tab can see this PR adds pyarrow as a dependency. The description of this PR should say why this change is being made.

If we're really adhering to software engineering best practices this PR should reference an issue which describes, in depth, the reasons for the changes here.

@dhirschfeld
Copy link
Contributor

So, I've gone to the trouble of checking out this codebase at this commit, and nowhere is pyarrow mentioned in this codebase.

If this codebase doesn't explicitly import a package, it shouldn't be listed as a dependency. This seems like a pretty clear-cut packaging bug but the intention is clear in the commit message. @jprakash-db why did you specifically add pyarrow as a dependency when this codebase doesn't use it?

@akoshel
Copy link

akoshel commented Mar 21, 2025

pyarrow makes this incompatible with databricks-sql-connector for python 3.13
https://github.com/databricks/databricks-sql-python/blob/v4.0.1/pyproject.toml#L25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants