Skip to content

Conversation

@benc-db
Copy link
Collaborator

@benc-db benc-db commented Oct 6, 2025

  • Upgraded ruff from 0.8.0 to 0.13.3 in pre-commit config
  • Upgraded mypy from 1.13.0 to 1.18.2 in pre-commit config and pyproject.toml
  • Fixed 101 import sorting issues automatically detected by ruff
  • Fixed 16 mypy type checking errors in 5 files:
    • constraints.py: Added assertion for non-None expression
    • relation_configs/constraints.py: Fixed Optional[str] handling and untyped import
    • handle.py: Added type ignore for missing databricks.sql stub
    • api_client.py: Added explicit dict[str, Any] type annotation
    • impl.py: Added type ignores for intentional subclass overrides

🤖 Generated with Claude Code

Checklist

  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have updated the CHANGELOG.md and added information about my change to the "dbt-databricks next" section.

@benc-db benc-db marked this pull request as ready for review October 6, 2025 16:19
@benc-db benc-db requested a review from ericj-db as a code owner October 6, 2025 16:19
- Upgraded ruff from 0.8.0 to 0.13.3 in pre-commit config
- Upgraded mypy from 1.13.0 to 1.18.2 in pre-commit config and pyproject.toml
- Fixed 101 import sorting issues automatically detected by ruff
- Fixed 16 mypy type checking errors in 5 files:
  - constraints.py: Added assertion for non-None expression
  - relation_configs/constraints.py: Fixed Optional[str] handling and untyped import
  - handle.py: Added type ignore for missing databricks.sql stub
  - api_client.py: Added explicit dict[str, Any] type annotation
  - impl.py: Added type ignores for intentional subclass overrides

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
@github-actions
Copy link

github-actions bot commented Oct 6, 2025

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  dbt/adapters/databricks
  api_client.py
  column.py
  connections.py
  constraints.py
  credentials.py
  handle.py
  impl.py
  logging.py
  parse_model.py
  relation.py
  utils.py
  dbt/adapters/databricks/behaviors
  columns.py
  dbt/adapters/databricks/catalogs
  _hive_metastore.py
  _unity.py
  dbt/adapters/databricks/python_models
  python_submissions.py
  dbt/adapters/databricks/relation_configs
  base.py
  column_comments.py
  column_tags.py
  comment.py
  constraints.py 37
  liquid_clustering.py
  query.py
  refresh.py
  tags.py
  tblproperties.py
Project Total  

The report is truncated to 25 files out of 28. To see the full report, please visit the workflow summary page.

This report was generated by python-coverage-comment-action

@benc-db benc-db merged commit bd89bb6 into 1.11.latest Oct 8, 2025
12 of 13 checks passed
@benc-db benc-db deleted the upgrade_ruff branch October 8, 2025 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants