Follow "More flexible cluster configuration". #194
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allisonwang-db
approved these changes
Sep 28, 2022
Collaborator
allisonwang-db
left a comment
allisonwang-db
left a comment
There was a problem hiding this comment.
This looks good! Thanks for the refactoring.
| return self.parsed_model.get( | ||
| "cluster_id", | ||
| self.credentials.extract_cluster_id( | ||
| self.parsed_model.get("http_path", self.credentials.http_path) |
Collaborator
There was a problem hiding this comment.
Can we specify an http_path that is different from the one in dbt profiles for a Python model?
Contributor
Author
There was a problem hiding this comment.
Thanks for the heads-up.
Actually I double-checked it and found there is a mistake. I'll update it.
After the update, yes, we can specify http_path in the Python model config that is different from the one in the profile.
def model(...):
dbt.config(http_path='...')
....or in dbt_project.yml file:
models:
- name: my_python_model
config:
http_path: ...
Co-authored-by: allisonwang-db <allison.wang@databricks.com>
Contributor
Author
|
Thanks! merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follows "More flexible cluster configuration" at dbt-labs/dbt-spark#467.
dbt-spark's implementationdatabricks-cli