Fix std.filter and std.filterMap to reject non-boolean predicate results instead of treating them as "false" #559
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug where
filter()andfilterMap()mishandled filter predicate results that weren't booleans: instead of failing with an error, jsonnet treated any non-boolean value as though it was false. For example:The problem was that evaluator code was checking
.isInstanceOf[Val.True]rather than explicitly checking for booleans (very similar to the past issue fixed in #44).This PR's fix is to update this logic to use
.asBoolean, which throws an explicit type error for non-booleans: