Skip to content

Tutorial #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sameeraxiomine wants to merge 15 commits into from
Closed

Tutorial #101

sameeraxiomine wants to merge 15 commits into from

Conversation

@sameeraxiomine
Copy link
Contributor

@sameeraxiomine sameeraxiomine commented Sep 30, 2015

Created the following set of files

  1. tutorial/README.md
  2. SparkRedshiftTutorial.scala
  3. images/loadreadstep.gif
  4. images/loadunloadstep.gif
  5. images/savetoredshift.gif

@sameeraxiomine
Spark-Redshift Tutorial
ef21821 
First Commiting Readme.md, source code and images
@sameeraxiomine
Revert original README.md
3d8d1e0
@sameeraxiomine
Tutorial
2010c57 
Update tutorial/README.md
@sameeraxiomine
Tutorial
7ec73c9 
Update image path
@sameeraxiomine
Tutorial
77bfe59 
Update images
@sameeraxiomine
Tutorial
ffc21ac 
Fixing the tutorial links
@sameeraxiomine
Tutorial
0e3963f 
Update Links
@sameeraxiomine
Tutorial
3974b7d 
Link to the entire program
@sameeraxiomine
Tutorial
efa1156 
Fix path
@sameeraxiomine
Tutorial
f7cd5c4 
Made more fixes to verbiage
@sameeraxiomine
Tutorial
5a15393 
Updates
@codecov-io
Copy link

codecov-io commented Sep 30, 2015

Current coverage is 87.16%

Merging #101 into master will decrease coverage by -7.65% as of df65fde

@@            master    #101   diff @@
======================================
  Files           11      11       
  Stmts          444     444       
  Branches       109     109       
  Methods          0       0       
======================================
- Hit            421     387    -34
  Partial          0       0       
- Missed          23      57    +34

Review entire Coverage Diff as of df65fde

Powered by Codecov. Updated on successful CI builds.

JoshRosen
JoshRosen reviewed Sep 30, 2015
View reviewed changes
tutorial/SparkRedshiftTutorial.scala Outdated
Copy link
Contributor

@JoshRosen JoshRosen Sep 30, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The spacing and indentation seems off in this file. Is it indented using a mixture of spaces and tabs? Please re-indent using only spaces.

Copy link
Contributor Author

@sameeraxiomine sameeraxiomine Sep 30, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have fixed this.

@JoshRosen
Copy link
Contributor

JoshRosen commented Sep 30, 2015

Not to nitpick, but I think PNG might be a better file format for images due to its better quality / compression ratios.

JoshRosen
JoshRosen reviewed Sep 30, 2015
View reviewed changes
tutorial/README.md Outdated
Copy link
Contributor

@JoshRosen JoshRosen Sep 30, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the full tutorial source is available as a .scala file, do you think we can cut down on some of the skeleton / harness here to make the prose read a bit more smoothly?

Copy link
Contributor Author

@sameeraxiomine sameeraxiomine Sep 30, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. Cut down the comments as they are included in the .scala program.

Copy link
Contributor Author

@sameeraxiomine sameeraxiomine Sep 30, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also changed as gif to png

JoshRosen
JoshRosen reviewed Sep 30, 2015
View reviewed changes
tutorial/README.md Outdated
Copy link
Contributor

@JoshRosen JoshRosen Sep 30, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

S3 should be capitalized.

@JoshRosen
Copy link
Contributor

JoshRosen commented Sep 30, 2015

I took one editing pass, but may have additional feedback. I would try reading the current draft aloud to find odd phrasing, typos, and misspellings, then take an editing pass to fix the mechanical issues.

@sameeraxiomine
Tutorial
40d1dbd 
Update based on comments received
@sameeraxiomine
Tutorial
f0f876b 
Update the tutorial contents
@sameeraxiomine
Tutorial
70eaf56 
Updates
@sameeraxiomine
Tutorial
eae938d 
Code fix
@sameeraxiomine
Copy link
Contributor Author

sameeraxiomine commented Oct 1, 2015

I updated the tutorial and source code based on your comments. I made some more of my own as I did a full pass through it.

@JoshRosen
Copy link
Contributor

JoshRosen commented Oct 15, 2015

I have some additional comments that I'd like to address, but I'm going to take care of them myself by submitting a followup PR. Therefore, I'm going to merge this now. Thanks!

@JoshRosen JoshRosen closed this in c72dc89 Oct 15, 2015
@JoshRosen JoshRosen mentioned this pull request Oct 15, 2015
Closed
JoshRosen added a commit that referenced this pull request Oct 17, 2015
@JoshRosen
Edits for tutorial
0a06c28 
This patch is a follow-up to #101 and makes many minor edits in the tutorial text.

/cc sameeraxiomine

Author: Josh Rosen <joshrosen@databricks.com>

Closes #106 from JoshRosen/tutorial-edits.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sameeraxiomine @codecov-io @JoshRosen