Skip to content

Fix for #118: StringType defaults to TEXT which is varchar(256) #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
eprochasson wants to merge 4 commits into from
Closed

Fix for #118: StringType defaults to TEXT which is varchar(256) #119

eprochasson wants to merge 4 commits into from

Conversation

@eprochasson
Copy link
Contributor

@eprochasson eprochasson commented Nov 5, 2015

also fixed a bit of documentation about compound key.

@codecov-io
Copy link

codecov-io commented Nov 5, 2015

Current coverage is 88.58%

Merging #119 into master will decrease coverage by -6.49% as of 64e3040

@@            master    #119   diff @@
======================================
  Files           12      12       
  Stmts          508     508       
  Branches       122     122       
  Methods          0       0       
======================================
- Hit            483     450    -33
  Partial          0       0       
- Missed          25      58    +33

Review entire Coverage Diff as of 64e3040

Powered by Codecov. Updated on successful CI builds.

JoshRosen
JoshRosen reviewed Nov 5, 2015
View reviewed changes
README.md Outdated
Copy link
Contributor

@JoshRosen JoshRosen Nov 5, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suuuuuper minor nit, but I'm slightly wary of putting this into example code that a user might verbatim copy-and-paste. Probably better to omit the use of a more powerful SaveMode.

@JoshRosen
Copy link
Contributor

JoshRosen commented Nov 5, 2015

Thanks for submitting this PR. I left a bunch of nitpicky comments because I'm kind of a perfectionist; if you don't have time to address them, I can take care of them myself on merge tomorrow.

@JoshRosen JoshRosen added this to the 0.5.3 milestone Nov 5, 2015
@JoshRosen JoshRosen self-assigned this Nov 5, 2015
@eprochasson
Copy link
Contributor Author

eprochasson commented Nov 5, 2015

Ha! Neh I'll do it.

@eprochasson
Copy link
Contributor Author

eprochasson commented Nov 5, 2015

I made the example slightly less abstract too.

JoshRosen
JoshRosen reviewed Nov 5, 2015
View reviewed changes
README.md
Copy link
Contributor

@JoshRosen JoshRosen Nov 5, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can still remove one level of braces, but I'll do this myself right now on merge.

@JoshRosen JoshRosen closed this Nov 5, 2015
@JoshRosen
Copy link
Contributor

JoshRosen commented Nov 5, 2015

Merged. Thanks!

JoshRosen pushed a commit that referenced this pull request Nov 5, 2015
@eprochasson @JoshRosen
Fix for #118: StringType defaults to TEXT which is varchar(256)
739e7ad 
also fixed a bit of documentation about compound key.

Author: Emmanuel Prochasson <eprochasson@gmail.com>

Closes #119 from eprochasson/master.
JoshRosen
JoshRosen reviewed Nov 5, 2015
View reviewed changes
README.md
Copy link
Contributor

@JoshRosen JoshRosen Nov 5, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noticed that there was also an extra ) here, so I fixed that as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@JoshRosen JoshRosen

Labels

bug documentation

Projects

None yet

Milestone

0.6.0

Development

Successfully merging this pull request may close these issues.

3 participants

@eprochasson @codecov-io @JoshRosen