Skip to content

Handle non-existent bucket in bucket lifecycle check #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
JoshRosen wants to merge 1 commit into from
Closed

Handle non-existent bucket in bucket lifecycle check #142

JoshRosen wants to merge 1 commit into from

Conversation

@JoshRosen
Copy link
Contributor

@JoshRosen JoshRosen commented Dec 27, 2015

This patch improves the error-handling in Utils.checkThatBucketHasObjectLifecycleConfiguration so that non-existent buckets result in a proper error message rather than a confusing NullPointerException (see #138).

@JoshRosen JoshRosen added the bug label Dec 27, 2015
@JoshRosen JoshRosen added this to the 0.5.3 milestone Dec 27, 2015
@JoshRosen JoshRosen mentioned this pull request Dec 27, 2015
Closed
@codecov-io
Copy link

codecov-io commented Dec 28, 2015

Current coverage is 88.97%

Merging #142 into master will decrease coverage by -0.12% as of 2957842

@@            master    #142   diff @@
======================================
  Files           13      13       
  Stmts          633     635     +2
  Branches       140     140       
  Methods          0       0       
======================================
+ Hit            564     565     +1
  Partial          0       0       
- Missed          69      70     +1

Review entire Coverage Diff as of 2957842

Powered by Codecov. Updated on successful CI builds.

@JoshRosen
Copy link
Contributor Author

JoshRosen commented Dec 28, 2015

Going to merge this now.

@JoshRosen JoshRosen closed this in 92c836a Dec 28, 2015
@JoshRosen JoshRosen deleted the handle-missing-bucket-in-lifecycle-check branch December 28, 2015 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

bug

Projects

None yet

Milestone

0.6.0

Development

Successfully merging this pull request may close these issues.

3 participants

@JoshRosen @codecov-io