Skip to content

Conversation

@JoshRosen
Copy link
Contributor

This patch moves the check for STS credentials into the AWSCredentials.load() call itself. The motivation for this is a single call-site where we forgot to do a .getOrElse(), which caused the STS credentials to be ignored. This broke spark-redshift for users who authenticated to AWS only via IAM instance profiles.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the callsite which was missing the params.temporaryAWSCredentials.getOrElse() call.

@codecov-io
Copy link

Current coverage is 88.97%

Merging #159 into master will decrease coverage by -0.02% as of b9fa8e2

@@            master    #159   diff @@
======================================
  Files           13      13       
  Stmts          645     644     -1
  Branches       142     142       
  Methods          0       0       
======================================
- Hit            574     573     -1
  Partial          0       0       
  Missed          71      71       

Review entire Coverage Diff as of b9fa8e2

Powered by Codecov. Updated on successful CI builds.

@JoshRosen JoshRosen closed this in 94aad1b Jan 19, 2016
@JoshRosen JoshRosen deleted the uniform-handling-of-sts-credentials branch January 19, 2016 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants