Log effective Redshift COPY statement #196
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This seems like a useful log message because: - It's reassuring to see that params set via extracopyoptions are actually used. - Currently the last log message one can see while COPY executes is CREATE TABLE logged a few lines before. This is a little confusing as can be understood as CREATE TABLE statement taking a long time. - There is a symmetric log message for UNLOAD statement in RedshiftRelation.scala.
Current coverage is
|
Contributor
|
LGTM, so I'm going to merge this now. Sorry for the delay. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems like a useful log message because:
actually used.
CREATE TABLE logged a few lines before. This is a little confusing as
can be understood as CREATE TABLE statement taking a long time.
RedshiftRelation.scala.