Fix decimal locale-sensitivity bug which caused incorrect reads #249
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 89.09% (diff: 100%)@@ master #249 diff @@
==========================================
Files 12 12
Lines 641 642 +1
Methods 562 561 -1
Messages 0 0
Branches 79 81 +2
==========================================
+ Hits 571 572 +1
Misses 70 70
Partials 0 0
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes an issue where our decimal parsing was locale-sensitive, causing the old code to return wrong answers when run in locales that use commas as decimal marks. Redshift will always use a dot (".") as the decimal point, so we can fix this bug by explicitly specifying a US locale when creating our
DecimalFormat.Fixes #243.