Fix reading of NaN and Infinity #269
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 89.44% (diff: 100%)@@ master #269 diff @@
==========================================
Files 12 12
Lines 648 654 +6
Methods 557 526 -31
Messages 0 0
Branches 91 128 +37
==========================================
+ Hits 579 585 +6
Misses 69 69
Partials 0 0
|
JoshRosen
added a commit
that referenced
this pull request
Sep 21, 2016
This patch fixes a bug which caused `spark-redshift` to throw `NumberFormatException` when reading NaN or Infinity from Redshift. This patch fixes the bug by adding special-case handling of the string constants `nan`, `inf`, and `-inf`, which are the values sent back by Redshift during unloads. Note that we still do not support loads of `NaN` to Redshift since Redshift itself does not seem to support this yet (https://forums.aws.amazon.com/thread.jspa?threadID=236367). Fixes #261. Author: Josh Rosen <joshrosen@databricks.com> Closes #269 from JoshRosen/fix-nan.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes a bug which caused
spark-redshiftto throwNumberFormatExceptionwhen reading NaN or Infinity from Redshift.This patch fixes the bug by adding special-case handling of the string constants
nan,inf, and-inf, which are the values sent back by Redshift during unloads. Note that we still do not support loads ofNaNto Redshift since Redshift itself does not seem to support this yet (https://forums.aws.amazon.com/thread.jspa?threadID=236367).Fixes #261.