Skip to content

Conversation

@JoshRosen
Copy link
Contributor

This patch refactors the driver-loading code so that it automatically uses either the Redshift JDBC 4.0 or 4.1 drivers, depending on which is installed. I also added support for automatically supplying an appropriate default JDBC driver class name when the postgres:// subprotocol is used.

I tested all of the error-handling corner-cases manually.

Fixes #83.

@JoshRosen JoshRosen added this to the 0.5.1 milestone Sep 15, 2015
@codecov-io
Copy link

Current coverage is 94.84%

Merging #90 into master will increase coverage by +0.03% as of 4835231

@@            master     #90   diff @@
======================================
  Files           11      11       
  Stmts          444     446     +2
  Branches       107     109     +2
  Methods          0       0       
======================================
+ Hit            421     423     +2
  Partial          0       0       
  Missed          23      23       

Review entire Coverage Diff as of 4835231

Powered by Codecov. Updated on successful CI builds.

@marmbrus
Copy link
Contributor

LGTM

@JoshRosen JoshRosen closed this in 43f9709 Sep 15, 2015
@JoshRosen JoshRosen deleted the auto-configure-jdbc-driver-class branch September 15, 2015 20:07
MasterDDT pushed a commit to ActionIQ-OSS/spark-redshift that referenced this pull request Aug 6, 2021
…ht_remove_sbt_spark_package

Remove reliance on sbt-spark-package
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants