[ISSUE] `databricks_service_principal_federation_policy` gives misleading error message for policy_id

[up-stevesloan]

This is simply a case that the constraints on the policy_id arg need to be tested and reported correctly. It is complaining about the character set used when in this case it should have complained about the length. We fixed this problem by trying a shorter policy_id.

Configuration

resource "databricks_service_principal_federation_policy" "project_circleci_federation" {

  service_principal_id = var.service_principal_id
  policy_id            = "project-test-project-service-principal-federation-policy-databricks-deployment-accelerator"

  oidc_policy = {
    issuer        = "https://oidc.circleci.com/org/${local.circle_ci_org_id}"
    audiences     = [local.circle_ci_org_id]
    subject       = var.project_id
    subject_claim = "oidc.circleci.com/project-id"
  }

Expected Behavior

Invalid federation policy id: 'project-test-project-service-principal-federation-policy-databricks-deployment-accelerator'. Policy ID must be xxx characters or fewer.

Actual Behavior

Invalid federation policy id: 'project-test-project-service-principal-federation-policy-databricks-deployment-accelerator'. Must contain only 0-9, a-z, and hyphen.

Steps to Reproduce

Terraform v1.11.4

on darwin_amd64

Note Databricks provider version:
- Installed databricks/databricks v1.100.0 (self-signed, key ID 92A95A66446BCE3F)

Is it a regression?

Unsure. Did not try other versions since this was the latest.

Debug Output

I think this issue would not be helped by debug output - it's simple enough.

Important Factoids

No.

Would you like to implement a fix?

If I ever get some free time...