Skip to content

Initial test coverage for configuration marshalling/unmarshalling #226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
asnare merged 1 commit into from
May 2, 2025
Merged

Initial test coverage for configuration marshalling/unmarshalling #226

asnare merged 1 commit into from
May 2, 2025

Conversation

@asnare
Copy link
Contributor

@asnare asnare commented Apr 16, 2025

This PR cherry-picks some unit tests from #189 (authored by @ericvergnaud) to provide some coverage of the existing code that marshals and unmarshals configurations. Given that there are some bugs in this area of the code, this helps us establish a baseline for what already works, and conversely what we're fixing and when.

@asnare
Cherry-pick passing tests from #189.
d9a8e50 
These provide some baseline coverage and behavior for serialising and deserialising configuration files.
@asnare asnare added the internal do not show this PR in changelog label Apr 16, 2025
@asnare asnare self-assigned this Apr 16, 2025
@asnare asnare requested a review from nfx as a code owner April 16, 2025 15:46
@github-actions
Copy link

github-actions bot commented Apr 16, 2025

✅ 40/40 passed, 3 flaky, 2 skipped, 2m17s total

Flaky tests:

  • 🤪 test_dbfs_as_fuse (10.013s)
  • 🤪 test_correctly_encodes_and_decodes_file_with_bom[\xff\xfe-utf-16-le] (10.012s)
  • 🤪 test_upload_wsfs (10.012s)

Running from acceptance #260

gueniai
gueniai approved these changes May 2, 2025
View reviewed changes
Copy link
Collaborator

@gueniai gueniai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@asnare asnare merged commit ab71201 into main May 2, 2025
11 checks passed
@asnare asnare deleted the test-coverage-config-serde branch May 2, 2025 15:44
ericvergnaud added a commit that referenced this pull request May 15, 2025
@ericvergnaud
Merge branch 'support-marshalling-of-object-and-any' of github.com:da…
179e504 
…tabrickslabs/blueprint into support-marshalling-of-object-and-any

* 'support-marshalling-of-object-and-any' of github.com:databrickslabs/blueprint:
  Initial test coverage for configuration marshalling/unmarshalling (#226)
  Fixed Blueprint Install (#225)
@asnare asnare mentioned this pull request Jun 16, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gueniai gueniai gueniai approved these changes

@ericvergnaud ericvergnaud Awaiting requested review from ericvergnaud

@sundarshankar89 sundarshankar89 Awaiting requested review from sundarshankar89

@nfx nfx Awaiting requested review from nfx

Assignees

@asnare asnare

Labels

internal do not show this PR in changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@asnare @gueniai