Skip to content

Conversation

@asnare
Copy link
Contributor

@asnare asnare commented Dec 30, 2025

This PR fixes some linting issues on main:

  • Dropped an unnecessary type parameter None on AsyncGenerator.
  • Removed type hints for unused arguments on methods that override system interfaces. Not having the hint makes it impossible for us to contradict the type hints on the system interfaces.

These are overrides, and the arguments are not used: leaving the type hints out means we don't unnecessarily contradict the hint on the base class (which occasionally changes).
@asnare asnare self-assigned this Dec 30, 2025
@asnare asnare requested a review from nfx as a code owner December 30, 2025 13:12
@asnare asnare added internal do not show this PR in changelog tech debt labels Dec 30, 2025
@asnare asnare added this to UCX Dec 30, 2025
@asnare asnare moved this to Ready for Review in UCX Dec 30, 2025
@github-actions
Copy link

✅ 40/40 passed, 2 skipped, 1m45s total

Running from acceptance #377

@codecov
Copy link

codecov bot commented Dec 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.07%. Comparing base (917730c) to head (0c04c79).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #321   +/-   ##
=======================================
  Coverage   80.07%   80.07%           
=======================================
  Files          17       17           
  Lines        2474     2474           
  Branches      533      533           
=======================================
  Hits         1981     1981           
  Misses        364      364           
  Partials      129      129           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@sundarshankar89 sundarshankar89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@asnare asnare merged commit d1d0030 into main Dec 30, 2025
14 checks passed
@asnare asnare deleted the fix/linting-errors branch December 30, 2025 13:32
@github-project-automation github-project-automation bot moved this from Ready for Review to Done in UCX Dec 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal do not show this PR in changelog tech debt

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants