Let page name adhere to naming restrictions #370
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ 36/36 passed, 4 skipped, 6m1s total Running from acceptance #492 |
gueniai
approved these changes
Feb 27, 2025
gueniai
added a commit
that referenced
this pull request
Feb 27, 2025
* Let page name adhere to naming restrictions ([#370](#370)). In this release, a new method `_clean_resource_name` has been introduced to modify resource names according to the updated naming convention, allowing only alphanumeric characters, hyphens, and underscores. The `as_lakeview` method in the `BaseHandler` class now uses this new method to ensure the `Page` class name adheres to the new restrictions. Furthermore, test files for dashboards have been updated to reflect the change, with a new test function `test_dashboard_metadata_as_lakeview_cleans_page_name` verifying that page names are free of special characters, and an existing test function modified to handle invalid dashboard YAML files. These changes improve consistency, reliability, and adherence to best practices in dashboard naming within the project.
Merged
gueniai
added a commit
that referenced
this pull request
Feb 27, 2025
* Let page name adhere to naming restrictions ([#370](#370)). In this release, a new method `_clean_resource_name` has been introduced to modify resource names according to the updated naming convention, allowing only alphanumeric characters, hyphens, and underscores. The `as_lakeview` method in the `BaseHandler` class now uses this new method to ensure the `Page` class name adheres to the new restrictions. Furthermore, test files for dashboards have been updated to reflect the change, with a new test function `test_dashboard_metadata_as_lakeview_cleans_page_name` verifying that page names are free of special characters, and an existing test function modified to handle invalid dashboard YAML files. These changes improve consistency, reliability, and adherence to best practices in dashboard naming within the project.
This was referenced Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let page names to adhere to the (new) naming convention:
Resource names should only contain alphanumeric characters (a-z, A-Z, 0-9), hyphens (-), or underscores (_)
Resolves #369