-
Notifications
You must be signed in to change notification settings - Fork 99
Closed
Labels
good first issueGood for newcomersGood for newcomersinternalthis pull request won't appear in release notesthis pull request won't appear in release notestech debtchores and design flawschores and design flaws
Description
Currently we have raise NotFound as a side_effect in the test_install.py as follows:
ws.workspace.get_status = not_foundwith:
ucx/tests/unit/install/test_install.py
Lines 98 to 100 in 2679758
| def not_found(_): | |
| msg = "save_config" | |
| raise NotFound(msg) |
Solution
The following should suffice and is more correct:
ws.workspace.get_status.side_effect = NotFoundNote: Please verify if the side effect is needed at all. It might not be in all the test cases
Metadata
Metadata
Assignees
Labels
good first issueGood for newcomersGood for newcomersinternalthis pull request won't appear in release notesthis pull request won't appear in release notestech debtchores and design flawschores and design flaws
Type
Projects
Status
Done