Skip to content

Conversation

@micheledaddetta-databricks
Copy link
Contributor

@micheledaddetta-databricks micheledaddetta-databricks commented Dec 13, 2024

Description

This feature aims to the chance of running SQL statement for assessment results export in case of large workspaces with a large amount of findings.
Introducing the query_statement_disposition value during the UCX installation can allow users to select the proper disposition method to use when running large queries. This parameter is added in the config.yml file and used for the SqlBackend definition. Using this approach, large queries will not fail.

Changes

Added SQL query statement disposition choice during the UCX installation
Added query_statement_disposition value in the config file

Linked issues

Resolves #3447

Functionality

  • modified existing commands: databricks labs install ucx, databricks labs ucx export-assessment

Tests

  • manually tested

Having this feature will allow the execution of queries with not negligible dimension results.
Using this field during the configuration, will allow to export assessment results for larger workspaces.
@micheledaddetta-databricks micheledaddetta-databricks requested a review from a team as a code owner December 13, 2024 16:48
Copy link
Contributor

@JCZuurmond JCZuurmond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@micheledaddetta-databricks : Thanks for the contribution. We need @gueniai to confirm your Github handle has the CLA signed. Can you make sure your git commits signature is verified (https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification)?

Co-authored-by: Cor <jczuurmond@protonmail.com>
@micheledaddetta-databricks
Copy link
Contributor Author

Hello @JCZuurmond thanks for taking in charge the request! I just set up my git commits signature. Is that an issue for previous commits?

@JCZuurmond
Copy link
Contributor

Hello @JCZuurmond thanks for taking in charge the request! I just set up my git commits signature. Is that an issue for previous commits?

I cannot tell, @gueniai can maybe figure this out for us

@gueniai
Copy link
Collaborator

gueniai commented Dec 19, 2024

Hi @micheledaddetta-databricks , thank you for the PR and for verifying the signature. Unfortunately the previous commits are not automatically also verified. You can try with an interactive rebase, but I have a feeling you're going to need to re-create the PR :/

@micheledaddetta-databricks micheledaddetta-databricks deleted the sql-statement-disposition-config branch December 19, 2024 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feat/cli CLI commands

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE]: Add Disposition parameter in SqlBackend creation

3 participants