-
Notifications
You must be signed in to change notification settings - Fork 99
Implement disposition field in SQL backend #3448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement disposition field in SQL backend #3448
Conversation
Having this feature will allow the execution of queries with not negligible dimension results. Using this field during the configuration, will allow to export assessment results for larger workspaces.
JCZuurmond
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@micheledaddetta-databricks : Thanks for the contribution. We need @gueniai to confirm your Github handle has the CLA signed. Can you make sure your git commits signature is verified (https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification)?
Co-authored-by: Cor <jczuurmond@protonmail.com>
|
Hello @JCZuurmond thanks for taking in charge the request! I just set up my git commits signature. Is that an issue for previous commits? |
I cannot tell, @gueniai can maybe figure this out for us |
|
Hi @micheledaddetta-databricks , thank you for the PR and for verifying the signature. Unfortunately the previous commits are not automatically also verified. You can try with an interactive rebase, but I have a feeling you're going to need to re-create the PR :/ |
Description
This feature aims to the chance of running SQL statement for assessment results export in case of large workspaces with a large amount of findings.
Introducing the
query_statement_dispositionvalue during the UCX installation can allow users to select the proper disposition method to use when running large queries. This parameter is added in theconfig.ymlfile and used for the SqlBackend definition. Using this approach, large queries will not fail.Changes
Added SQL query statement disposition choice during the UCX installation
Added
query_statement_dispositionvalue in the config fileLinked issues
Resolves #3447
Functionality
databricks labs install ucx,databricks labs ucx export-assessmentTests