Skip to content

Put back dashboard names #3808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JCZuurmond merged 2 commits into from
Mar 3, 2025
Merged

Put back dashboard names #3808

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d92bd77
Revert "Partial revert "Let dashboard name adhere to naming conventio…
JCZuurmond Mar 3, 2025
270cdf0
Put back original dashboard name
JCZuurmond Mar 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/databricks/labs/ucx/install.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -662,7 +662,7 @@ def _create_dashboard(self, folder: Path, *, parent_path: str) -> None:
catalog_to_replace="ucx_catalog",
)
)
metadata.display_name = self._name(f"{folder.parent.stem.title()}_{folder.stem.title()}")
metadata.display_name = self._name(f"{folder.parent.stem.title()} ({folder.stem.title()})")
reference = f"{folder.parent.stem}_{folder.stem}".lower()
dashboard_id = self._install_state.dashboards.get(reference)
if dashboard_id is not None:
Expand Down
2 changes: 1 addition & 1 deletion src/databricks/labs/ucx/installer/mixins.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ def __init__(self, config: WorkspaceConfig, installation: Installation, ws: Work

def _name(self, name: str) -> str:
prefix = os.path.basename(self._installation.install_folder()).removeprefix('.')
return f"{prefix.upper()}_{name}"
return f"[{prefix.upper()}] {name}"

@property
def _my_username(self):
Expand Down
4 changes: 2 additions & 2 deletions tests/unit/install/test_install.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ def test_install_cluster_override_jobs(ws, mock_installation) -> None:

workflows_installation.create_jobs()

tasks = created_job_tasks(ws, 'MOCK_assessment')
tasks = created_job_tasks(ws, '[MOCK] assessment')
assert tasks['assess_jobs'].existing_cluster_id == 'one'
assert tasks['crawl_grants'].existing_cluster_id == 'two'
wheels.upload_to_wsfs.assert_called_once()
Expand All @@ -175,7 +175,7 @@ def test_writeable_dbfs(ws, tmp_path, mock_installation) -> None:

workflows_installation.create_jobs()

job = created_job(ws, 'MOCK_assessment')
job = created_job(ws, '[MOCK] assessment')
job_clusters = {_.job_cluster_key: _ for _ in job['job_clusters']}
assert 'main' in job_clusters
assert 'tacl' in job_clusters
Expand Down