Update integration test with new SPN ID #4704
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pritishpai
temporarily deployed
to
account-admin
GitHub Actions
Inactive
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4704 +/- ##
=======================================
Coverage ? 87.94%
=======================================
Files ? 123
Lines ? 17570
Branches ? 3714
=======================================
Hits ? 15452
Misses ? 1425
Partials ? 693 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
✅ 55/55 passed, 5 skipped, 2h52m28s total Running from acceptance #8942 |
pritishpai
had a problem deploying
to
account-admin
GitHub Actions
Error
pritishpai
temporarily deployed
to
account-admin
GitHub Actions
Inactive
FastLee
approved these changes
Oct 27, 2025
Contributor
FastLee
left a comment
FastLee
left a comment
There was a problem hiding this comment.
LGTM. Related to a labs-infra PR.
sundarshankar89
added a commit
that referenced
this pull request
Nov 13, 2025
* Added a dataframe call matcher for linting tables ([#4664](#4664)). The library has been enhanced with several new features and improvements. A new method has been introduced to check if a given call node represents a DataFrame method call, such as `df.write.mode().saveAsTable()` or `df.write.saveAsTable()`, by verifying the call chain and intermediate calls. This method is utilized by the existing `matches` method to correctly identify DataFrame method calls for linting purposes. Additionally, the `pick_owner_group` method has been updated to filter out groups with `None` display names, ensuring that the user is only presented with valid group options. Furthermore, a new test method has been added to collect and lint DataFrame calls, such as `df.write[.mode()].saveAsTable()`, to ensure that used tables are correctly identified in PySpark code, covering various scenarios and utilizing relevant classes to provide context for the linter. * Updated integration test with new SPN ID ([#4704](#4704)). The migration of external tables with a service principal name (SPN) in an Azure environment has been enhanced for improved security and flexibility. Instead of relying on a hardcoded SPN client ID, the test case now retrieves the ID from a secret store, utilizing a secure method to manage sensitive credentials. This change allows for better protection and easier rotation of credentials, aligning with best practices for handling confidential information. * Updates documentation with installation prompt details ([#4399](#4399)). The installation process for Unity Catalog migration has been enhanced to provide a more guided and user-friendly experience, featuring interactive prompts that walk users through configuring their migration settings. These prompts cover a range of aspects, including basic configuration, migration strategies, database and table settings, ownership and validation reconciliation, SQL warehouse selection, network and dependency configuration, and post-installation steps. With validation and orchestration handled by the installation classes, users can easily configure and deploy their workspaces to Unity Catalog, with support for advanced scenarios such as forced installation prompts and joining existing collections, which require account admin privileges, resulting in a more streamlined and customizable migration experience.
sundarshankar89
added a commit
that referenced
this pull request
Nov 13, 2025
* Added a dataframe call matcher for linting tables ([#4664](#4664)). Improved linting: Enhanced table checks and fixed group selection issues. * Updated integration test with new SPN ID ([#4704](#4704)). Improved authentication: Enhanced integration with secure ID updates. * Updates documentation with installation prompt details ([#4399](#4399)). Simplified installation: Added guidance on UCX install prompts, improving user experience.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Update test will new SPN ID with a short term fix. Added a new bug for fixing it later.
Resolves #4703