This repository was archived by the owner on May 2, 2023. It is now read-only.
Databricks: support 3 part id #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Wasn't sure of the best way to test this since databricks tests are limited at the moment. But you can see the
|
Contributor
|
Looks good. But the test in the screenshot isn't included in the PR. |
Contributor
|
I think a better test would be to create and the drop a table, 3 times, once for each possible length, and make sure there is no error. |
Contributor
Author
Manually? We don't include Databricks at all in automated tests currently |
Contributor
|
That's fine. LGTM |
This was referenced Feb 6, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Databricks supports a 3-part identifier in queries (catalog.schema.table)