Merged
Conversation
Restores navigation entries that were incorrectly removed in PR #134: - how-to/manage-secrets.md → Setup section - how-to/object-storage-overview.md → Object Storage section - how-to/choose-storage-type.md → Object Storage section These files exist but were missing from the sidebar navigation. Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
Only --- is now accepted. Also fixed terminology: - "secondary attributes" → "dependent attributes" Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Add hidden attributes section to table-declaration.md - Attributes prefixed with _ are hidden - Excluded from heading.attributes, fetch, joins, dict restrictions - Accessible via string restrictions and explicit fetch - Add dict restriction behavior to query-algebra.md - Unmatched keys silently ignored - Empty match evaluates to True (all rows) - Rationale and caution notes Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Collaborator
MilagrosMarin
left a comment
There was a problem hiding this comment.
Thanks for merging the v2.1 updates! I verified the technical claims against datajoint-python pre/v2.1 source:
✅ Verified:
___separator removal (only---in pre/v2.1declare.py:363)- Hidden attributes behavior (
heading.py:232,condition.py:376) - Dict restriction unmatched keys (
condition.py:375-387) - Nav target files exist on
pre/v2.1
Found a couple of items that need attention - see inline comments.
- Replace fetch() with to_dicts()/to_pandas() (removed in DJ 2.0) - Update hidden attribute examples to use proj() + to_dicts() - Add note linking "dependent attributes" to API term "secondary_attributes" Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Replace "dependent attributes" with "secondary attributes" throughout: - Matches Python API: heading.secondary_attributes - Consistent with existing documentation (~24 occurrences) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Re-run all tutorials against PostgreSQL with TLS disabled - Add scripts/execute-notebooks.sh for reproducible execution Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Member
Author
Addressed Review CommentsThanks @MilagrosMarin for the thorough review! Comment 1 & 2:
|
Collaborator
|
Thank you, @dimitri-yatsenko! This PR looks good to me now. |
MilagrosMarin
approved these changes
Jan 23, 2026
MilagrosMarin
approved these changes
Jan 23, 2026
This was referenced Jan 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Merge
pre/v2.1documentation updates intomain.Changes
Navigation
manage-secrets.md→ Setup sectionobject-storage-overview.md→ Object Storage sectionchoose-storage-type.md→ Object Storage sectionTable Declaration Spec
___as alternative separator (only---now accepted)_-prefixed)Query Algebra Spec
Test plan
🤖 Generated with Claude Code