fix: allow attribute names starting with 'index' in declarations#1412
Merged
dimitri-yatsenko merged 1 commit intomasterfrom Mar 9, 2026
Merged
fix: allow attribute names starting with 'index' in declarations#1412dimitri-yatsenko merged 1 commit intomasterfrom
dimitri-yatsenko merged 1 commit intomasterfrom
Conversation
The index detection regex in declare.py matched any line starting with "index", misclassifying attributes like `index: int` or `index_value` as index declarations. Tighten the regex to require parentheses, matching only actual index declarations like `index(col1, col2)`. Also fix pre-existing mypy errors: add type annotations to hash_registry.py functions and assert-based narrowing for conditional config imports in filepath.py, attach.py, and hash_registry.py. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
ttngu207
approved these changes
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
declare.py:373to require parentheses, preventing attribute names likeindex,index_id,index_valuefrom being misclassified as index declarationstest_regex_mismatchto verify these attributes now declare successfully (renamed totest_index_attribute_name)hash_registry.py,filepath.py, andattach.py(type annotations + assert narrowing for conditional config imports)Closes #1411
Test plan
test_index_attribute_namepasses on MySQL and PostgreSQL — attributes namedindexandindex_valuedeclare and appear in headingindex(col)syntax unaffected)🤖 Generated with Claude Code