Added basic list_tables function for schema class#844
Added basic list_tables function for schema class#844dimitri-yatsenko merged 7 commits intodatajoint:masterfrom
Conversation
There was a problem hiding this comment.
Thanks @Synicix for the PR. In addition to the provided inline feedback, I would suggest to add at least one test to validate the feature. Otherwise, our coverage will go down. It could simply be to create a table and then verify that it is returned when invoking the class method. Also, adding 'Fix #838' to the description of your PR will auto-close the issue once merged to the default branch.
Ugh, looks like there was a recent release (yesterday!) of minio python package that broke some S3 features. Such is the nature of development... Could you also track down the nature of the failure and see if it is easy to patch? You should be able to inspect the tests in GitHub Actions or locally to get a good idea of what is happening. Worst case scenario, we can version pin it to the last release. You can also file an issue regarding it.
|
Need to add tests, please wait for that commmit before reviewing |
|
Will look into the minio errors in a different pull request |
|
#847 In progress, probably will fix that first then have this update with that test fix to pass the requirements. |
guzman-raphael
left a comment
There was a problem hiding this comment.
See inline comment.
|
#838 Partially implmented for now |
|
fix #838 |
I just added what I needed for DJGUI for now, as such it returns the raw names to be parsed by the API on the other side.
I can add additional features as people request them like restricting by lookup tables are returning it in a different format.