Fix complex date restriction regression and various others#893
Merged
dimitri-yatsenko merged 23 commits intodatajoint:masterfrom Apr 15, 2021
Merged
Conversation
ixcat
approved these changes
Mar 25, 2021
guzman-raphael
requested review from
Synicix,
dimitri-yatsenko,
mahos and
shenshan
and removed request for
shenshan
| def test_complex_date_restriction(): | ||
| # https://github.com/datajoint/datajoint-python/issues/892 | ||
| """Test a complex date restriction""" | ||
| q = OutfitLaunch & 'day between curdate() - interval 30 day and curdate()' |
Member
There was a problem hiding this comment.
month, day, year, week?
datajoint/diagram.py
Outdated
| Make the self.graph - a graph object ready for drawing | ||
| """ | ||
| # mark "distinguished" tables, i.e. those that introduce new primary key attributes | ||
| # mark "distinguished" tables i.e. ones introduce new primary key attributes |
Member
There was a problem hiding this comment.
The wording before was more correct.
dimitri-yatsenko
approved these changes
Mar 26, 2021
Member
dimitri-yatsenko
left a comment
dimitri-yatsenko
left a comment
There was a problem hiding this comment.
great improvements! Just minor comments.
dimitri-yatsenko
approved these changes
Apr 12, 2021
CHANGELOG.md
Outdated
| ## Release notes | ||
|
|
||
| ### 0.13.1 -- TBD | ||
| * Add `None` as an alias for `NULL` in `dict` restrictions (#824) PR #893 |
Member
There was a problem hiding this comment.
Suggested change
| * Add `None` as an alias for `NULL` in `dict` restrictions (#824) PR #893 | |
| * Add `None` as an alias for `IS NULL` comparison in `dict` restrictions (#824) PR #893 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses:
schema.list_tables()#838