Skip to content

fix(probe_geometry): bugfix in x_coords for probe with staggered electrode positions #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kushalbakshi merged 2 commits into from
Jan 12, 2024
Merged

fix(probe_geometry): bugfix in x_coords for probe with staggered electrode positions #181

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
54d4fac
fix(probe_geometry): bugfix in x_coords for probe with staggered elec…
Jan 12, 2024
2e79f3d
update(version): update CHANGELOG and version
Jan 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,9 @@
Observes [Semantic Versioning](https://semver.org/spec/v2.0.0.html) standard and
[Keep a Changelog](https://keepachangelog.com/en/1.0.0/) convention.

## [0.3.2] - 2024-01-12
+ Fix - `probe_geometry` bugfix for incorrect handling of probes with staggered electrode positions

## [0.3.1] - 2023-11-28
+ Update - Flowchart borders for consistency with other DataJoint Elements
+ Fix - `dj.config()` setup moved to `tutorial_pipeline.py` instead of `__init__.py`
Expand Down
2 changes: 1 addition & 1 deletion element_array_ephys/readers/probe_geometry.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,7 @@ def build_electrode_layouts(
row_offset = np.zeros_like(x_coords)
else:
assert len(row_offset) == row_count
row_offset = np.tile(row_offset, col_count_per_shank)
row_offset = np.repeat(row_offset, col_count_per_shank)
x_coords = x_coords + row_offset

shank_cols = np.tile(range(col_count_per_shank), row_count)
Expand Down
2 changes: 1 addition & 1 deletion element_array_ephys/version.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
"""Package metadata."""
__version__ = "0.3.1"
__version__ = "0.3.2"