Skip to content

Use IExternalScopeProvider for logging scopes #36

@davidfowl

Description

@davidfowl

No need to store a custom async local, the default logger factory can provide a scope implementation via the ISupportExternalScope and IExternalScopeProvider interfaces. See https://github.com/dotnet/runtime/blob/23919a4b58d888b92f5192576febf47b06942b2c/src/libraries/Microsoft.Extensions.Logging.EventLog/src/EventLogLoggerProvider.cs#L66 for more details and feel free to ping me (or I can send a PR if you agree 😄 )..

This automagically gets you features like dotnet/runtime#34305 when using the default logger factory instance.

cc @nblumhardt

Metadata

Metadata

Assignees

No one assigned

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions