Add forwarder config#321
Merged
liammclennan merged 5 commits intodatalust:feature/forwarderfrom Feb 29, 2024
Merged
Conversation
nblumhardt
reviewed
Feb 29, 2024
src/SeqCli/Config/SeqCliConfig.cs
Outdated
| public SeqCliOutputConfig Output { get; set; } = new(); | ||
| public SeqCliStorageConfig Storage { get; set; } = new(); | ||
| public SeqCliDiagnosticConfig Diagnostics { get; set; } = new(); | ||
| public SeqCliApiConfig Api { get; set; } = new(); |
Member
There was a problem hiding this comment.
Perhaps these three would be best grouped under a Forwarder sub-object? Settings like api.listenUri are a little vague when viewed from the general seqcli perspective, they'd be easier to read/understand as forwarder.api.listenUri 🤔
nblumhardt
reviewed
Feb 29, 2024
| public string ServerUrl { get; set; } = "http://localhost:5341"; | ||
| public ulong EventBodyLimitBytes { get; set; } = 256 * 1024; | ||
| public ulong RawPayloadLimitBytes { get; set; } = 10 * 1024 * 1024; | ||
| public uint? PooledConnectionLifetimeMilliseconds { get; set; } = null; |
Member
There was a problem hiding this comment.
I'd be tempted to move PooledConnectionLifetimeMilliseconds under a fowarder.connection section, too.
If we put EventBodyLimitBytes and RawPayloadLimitBytes at this level, could we apply them as defaults to the other output commands?
nblumhardt
reviewed
Feb 29, 2024
|
|
||
| public string ServerUrl { get; set; } = "http://localhost:5341"; | ||
| public ulong EventBodyLimitBytes { get; set; } = 256 * 1024; | ||
| public ulong RawPayloadLimitBytes { get; set; } = 10 * 1024 * 1024; |
Member
There was a problem hiding this comment.
The Raw* in this name used to refer to the "raw" (as opposed to CLEF) output format. It might be better named just PayloadLimitBytes now, I think.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.