Tidy up ForwardingChannel shut-down logic#409
Merged
nblumhardt merged 5 commits intodatalust:devfrom Jul 23, 2025
Merged
Conversation
…that in-flight batches aren't hard-cancelled
…asks, opportunistically fix some path issues and simplify `forwarder install`.
nblumhardt
commented
Jul 22, 2025
| Options.Add( | ||
| "setup", | ||
| "Install and start the service only if it does not exist; otherwise reconfigure the binary location", | ||
| _ => _setup = true); |
Member
Author
There was a problem hiding this comment.
The Seq codebase, an earlier version of which this came from, includes a --setup flag on its service install command to handle reconfiguration during MSI upgrades, in case the user chose a different path to install the Seq binaries.
seqcli forwarder doesn't need that - it's sufficient to be able to forwarder uninstall and forwarder install at the command line, if the seqcli binaries move.
liammclennan
approved these changes
Jul 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just a minor tweak to bail out of the shipper as early in the process as possible.
Spotted some holes in exception handling in the process. It would be nice now to extract some real functions for the
ForwardingChannelpump tasks, but skipping for now to avoid conflicts.Also spotted some holes in
forwarder installand gave that a quick once-over on the way through :-)Getting close to a usable preview forwarder now! 😁 ... Or, closer, anyway!