Skip to content

Updated some date time operators to be marked as deterministic#42

Merged
rob-reynolds merged 1 commit intomasterfrom
MSSqlDeviceMakeDateFunctionsDeterministic
Jul 4, 2018
Merged

Updated some date time operators to be marked as deterministic#42
rob-reynolds merged 1 commit intomasterfrom
MSSqlDeviceMakeDateFunctionsDeterministic

Conversation

@JPercival
Copy link
Copy Markdown
Contributor

@JPercival JPercival commented Jul 3, 2018 •
edited
Loading

  • Updated DTWrite operators to be create with schemabinding so that they are marked as deterministic
  • In additoon, updated DateTimeSelector to make the base datetime conversion deterministic

@JPercival JPercival self-assigned this Jul 3, 2018
@JPercival JPercival mentioned this pull request Jul 3, 2018
Open
rob-reynolds
rob-reynolds approved these changes Jul 4, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@rob-reynolds rob-reynolds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rob-reynolds rob-reynolds merged commit 239ba6d into master Jul 4, 2018
@rob-reynolds rob-reynolds deleted the MSSqlDeviceMakeDateFunctionsDeterministic branch July 4, 2018 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brynrhodes brynrhodes Awaiting requested review from brynrhodes

1 more reviewer

@rob-reynolds rob-reynolds rob-reynolds approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@JPercival JPercival

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JPercival @rob-reynolds