Skip to content

Conversation

@joshcorr
Copy link
Contributor

Type of Change

  • Bug fix (non-breaking change, fixes Fix PSUseBOMForUnicodeEncodedFile #4339 )
  • New feature (non-breaking change, adds functionality)
  • Breaking change (effects multiple commands or functionality)
  • Ran manual Pester test and has passed (`.\tests\manual.pester.ps1)
  • Adding code coverage to existing functionality
  • Pester test is included
  • Nunit test is included
  • Documentation
  • Build system

Purpose

Remove characters that can not be rendered in UTF-8 non BOM files.

Approach

Tried to replace characters, but they still showed up as extended characters
Removed characters that broke the PSSA rule (some of which do not render).

Commands to test

Invoke-ScriptAnalyzer .\functions\ -IncludeRule PSUseBOMForUnicodeEncodedFile

@potatoqualitee
Copy link
Member

😍 😍

@potatoqualitee potatoqualitee merged commit 1b116f7 into dataplat:development Oct 25, 2018
@joshcorr joshcorr deleted the fix-PSUseBOMForUnicodeEncodedFile branch November 12, 2018 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix PSUseBOMForUnicodeEncodedFile

2 participants