Add manual account requests #31
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Poizon7
changed the title
Poizon7
force-pushed
the
manual_account_requests
branch
from
f3a7c91 to
4bf72af
Compare
foodelevator
requested changes
Dec 15, 2025
Comment on lines
18
to
28
| alter table account_requests | ||
| drop column ug_kthid text; | ||
|
|
||
| alter table account_requests | ||
| drop column first_name text; | ||
|
|
||
| alter table account_requests | ||
| drop column family_name text; | ||
|
|
||
| alter table account_requests | ||
| drop column email text; |
Member
There was a problem hiding this comment.
Suggested change
| alter table account_requests | |
| drop column ug_kthid text; | |
| alter table account_requests | |
| drop column first_name text; | |
| alter table account_requests | |
| drop column family_name text; | |
| alter table account_requests | |
| drop column email text; | |
| alter table account_requests | |
| drop column ug_kthid | |
| alter table account_requests | |
| drop column first_name; | |
| alter table account_requests | |
| drop column family_name; | |
| alter table account_requests | |
| drop column email; |
| started = "Internal server started" | ||
| } | ||
| slog.Info(started, "address", "http://localhost:"+port, "config", config.Config) | ||
| slog.Info(started, "address", "http://localhost:"+port) |
Member
There was a problem hiding this comment.
i would kind of like to keep this in dev, but yeah it was leaking secrets in prod which is perhaps not ideal
handlers/admin.go
Outdated
| Email: accountRequest.Email, | ||
| FirstName: accountRequest.FirstName, | ||
| FamilyName: accountRequest.FamilyName, | ||
| YearTag: accountRequest.Email, |
Member
There was a problem hiding this comment.
Suggested change
| YearTag: accountRequest.Email, | |
| YearTag: accountRequest.YearTag, |
handlers/user.go
Outdated
|
|
||
| _, err := s.DB.CreateAccountRequestManual(r.Context(), database.CreateAccountRequestManualParams{ | ||
| Kthid: kthid, | ||
| UgKthid: "ug" + kthid, |
Member
There was a problem hiding this comment.
is this really a good idea? i would probably do something like dsekt: so that it definitely won't crash. if i recall correctly, they always start with u1, so i guess this might never collide anyways
| <form class="p-6 flex flex-col gap-4" hx-post="/request-account"> | ||
| <label for="reference"> | ||
| Reference: <span class="text-sm">(a person)</span> | ||
| Reference: <span class="text-sm">(a person who can vouch for you)</span> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements manual account requests by allowing the user to add all the information we'd usually get from kth ldap
resolves #27