Skip to content

Conversation

@JesusTheHun
Copy link
Contributor

Closes #97

Node v22 gets rid of the assert keyword, which is used by one of the rollup plugins we used.

Rollup had major internal and plugin updates. Those updated versions no longer use this keyword.
This PR updates the rollup plugins we use and the config file accordingly.

On a side note : after building, the output directory now contains the bundled and unbundled type definitions.
To avoid packaging them both (only the bundled ones are required), I've also updated the files property of the package.json.

Copy link
Member

@curran curran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you.

@curran curran merged commit 7497880 into datavis-tech:master Dec 4, 2024
@curran
Copy link
Member

curran commented Dec 4, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Build Breakage on Latest NodeJS

2 participants