Fix/shortest paths #71
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
curran
requested changes
Aug 4, 2023
Member
curran
left a comment
curran
left a comment
There was a problem hiding this comment.
Excellent work! I have a few suggestions here.
src/index.ts
Outdated
| removeEdge(path[0], path[1]); | ||
| removeEdge(path[1], path[0]); | ||
| removedEdges.push([path[0], path[1]]); | ||
| [ |
Member
There was a problem hiding this comment.
This code creates many new arrays and one new closure each time it runs, which could degrade performance as all of those things need to be garbage collected.
I would suggest the following refactoring:
const u = path[0];
const v = path[1];
if (hasEdge(u, v)) {
removedEdges.push({ u, v, weight: getEdgeWeight(u, v) });
removeEdge(u, v);
}
if (hasEdge(v, u)) {
removedEdges.push({ u: v, v: u, weight: getEdgeWeight(v, u) });
removeEdge(v, u);
}
| return d === item; | ||
| }).length > 0 | ||
| ); | ||
| return arr.includes(item); |
src/index.ts
Outdated
| let path = shortestPath(source, destination); | ||
| const paths = [path], | ||
| removedEdges = [], | ||
| removedEdges: any = [], |
Member
There was a problem hiding this comment.
I bet it's possible to add proper types here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Better to check if the link really exists before deletion otherwise it can create unwanted links at the end